Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url in build_dftd3a.sh #1054

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix url in build_dftd3a.sh #1054

merged 1 commit into from
Dec 9, 2024

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Dec 3, 2024

Closes #1053

I guess this was never tested.

Copy link
Collaborator

@jeffhammond jeffhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified as correct

@jeffhammond
Copy link
Collaborator

LGTM but I will let @edoapra hit the merge button.

@edoapra
Copy link
Collaborator

edoapra commented Dec 9, 2024

Closes #1053

I guess this was never tested.
I agree that the first URL was incorrect, but the second one out of webarchive.org used to work until a few weeks ago.
Therefore, please keep your rushed conclusion to yourself.
We do extensive tests of NWChem as anyone can see from the github action logs.
I have not been able to spot the same level of robust testing in spack yet.

@edoapra edoapra merged commit e69ee7e into nwchemgit:master Dec 9, 2024
63 checks passed
@chenrui333
Copy link

@edoapra currently the build failed, any chance to cut a new release for this PR fix? thanks!

@edoapra
Copy link
Collaborator

edoapra commented Dec 27, 2024

@edoapra currently the build failed, any chance to cut a new release for this PR fix? thanks!

@chenrui333 This is for the NWChem homebrew recipe, right?

@edoapra
Copy link
Collaborator

edoapra commented Dec 27, 2024

@edoapra currently the build failed, any chance to cut a new release for this PR fix? thanks!
@chenrui333
It sounds like you have already applied this fix ... isn't it?
Homebrew/homebrew-core@646bfc5
Homebrew/homebrew-core@646bfc5#diff-6f40a68c218c50c802e5a7cb64a559f6ac3f8bb8e7541f5929373a18ac6b5af1R39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with downloading DFT-D3 library
4 participants